#59: Implemented a mechanism to read the environment info from the test container#61
Merged
Merged
Conversation
20cb6ea to
d8b637a
Compare
2. Added new test to CI
Generalized implementation
f70e009 to
222d2fc
Compare
kaklakariada
previously approved these changes
Jun 10, 2024
kaklakariada
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #59
Also simplified execution of CI builds: Removed unnecessary wrapper scripts for Poetry (Poetry is now already installed by the exasol-toolbox GH action)
It turned out that the wrapper scripts always used Python3.10 for execution, even when the Matrix build was running Python3.11 and Python3.12. Python3.12 has too many issues for now (packages
asyncore,smptdand possible others were removed). So the supported for Python3.12 was dropped for now.A more generic approach was used to provide the reading of the environment info. As the
/environment_info.jsonis responsibility of the integration_test_docker_environment, which however is not a dependency to this project, a simple converter class was provided which reads a json file and converts it to an object with the JSON keys as attributes of the object.It was decided to not use (munch in order to reduce dependencies.
It's then the client responsibility to call the new method
utils.obj_from_json_file('/environment_info.json')All Submissions: