Skip to content

#59: Implemented a mechanism to read the environment info from the test container#61

Merged
tomuben merged 6 commits into
masterfrom
feature/59_provide_environment_info
Jun 10, 2024
Merged

#59: Implemented a mechanism to read the environment info from the test container#61
tomuben merged 6 commits into
masterfrom
feature/59_provide_environment_info

Conversation

@tomuben
Copy link
Copy Markdown
Collaborator

@tomuben tomuben commented Jun 7, 2024

fixes #59

Also simplified execution of CI builds: Removed unnecessary wrapper scripts for Poetry (Poetry is now already installed by the exasol-toolbox GH action)
It turned out that the wrapper scripts always used Python3.10 for execution, even when the Matrix build was running Python3.11 and Python3.12. Python3.12 has too many issues for now (packages asyncore, smptd and possible others were removed). So the supported for Python3.12 was dropped for now.

A more generic approach was used to provide the reading of the environment info. As the /environment_info.json is responsibility of the integration_test_docker_environment, which however is not a dependency to this project, a simple converter class was provided which reads a json file and converts it to an object with the JSON keys as attributes of the object.
It was decided to not use (munch in order to reduce dependencies.
It's then the client responsibility to call the new method utils.obj_from_json_file('/environment_info.json')

All Submissions:

  • Is the title of the Pull Request correct?
  • Is the title of the corresponding issue correct?
  • Have you updated the changelog?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you mentioning the issue which this PullRequest fixes ("Fixes...")

@tomuben tomuben changed the title #59: Implemented a mechanism to read the environment info from the te… #59: Implemented a mechanism to read the environment info from the test container Jun 7, 2024
@tomuben tomuben force-pushed the feature/59_provide_environment_info branch from 20cb6ea to d8b637a Compare June 7, 2024 12:12
@tomuben tomuben force-pushed the feature/59_provide_environment_info branch from f70e009 to 222d2fc Compare June 7, 2024 18:53
kaklakariada
kaklakariada previously approved these changes Jun 10, 2024
@tomuben tomuben merged commit 160a765 into master Jun 10, 2024
@tomuben tomuben deleted the feature/59_provide_environment_info branch June 10, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a mechanism to read the environment info from the test container

2 participants