#169 Added open_bucketfs_location function #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
reviewed
Mar 13, 2025
| # Connect to the BucketFS service and navigate to the bucket of choice. | ||
| bucketfs = bfs.Service(buckfs_url, buckfs_credentials, verify, conf.get(CKey.bfs_service)) # type: ignore | ||
| return bucketfs[conf.get(CKey.bfs_bucket)] # type: ignore | ||
| bucketfs = bfs.Service(bucketfs_url, bucketfs_credentials, verify, # type: ignore |
Collaborator
There was a problem hiding this comment.
Is the type ignore still needed, I think, Bucketfs provides now py.typed
Collaborator
Author
There was a problem hiding this comment.
Yes, we define bucketfs_credentials here as a dictionary, but in the interface it's Mapping.
Collaborator
There was a problem hiding this comment.
Interesting that they are not compatible
tkilias
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #169