Skip to content

#1442: Added new preprocessor flag USE_STATIC_SWIG#636

Merged
tomuben merged 5 commits intomasterfrom
refactoring/1442_add_new_preprocessor_flag_use_static_swig
Apr 20, 2026
Merged

#1442: Added new preprocessor flag USE_STATIC_SWIG#636
tomuben merged 5 commits intomasterfrom
refactoring/1442_add_new_preprocessor_flag_use_static_swig

Conversation

@tomuben
Copy link
Copy Markdown
Collaborator

@tomuben tomuben commented Apr 20, 2026

Comment thread exaudfclient/exaudfclient.cc Outdated
}
#endif

#ifdef UDF_PLUGIN_CLIENT
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Udfplugin use there own main, we can remove the ifdef

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread exaudfclient/exaudfclient.cc Outdated
// udf plugins might not have arguments
#else
if (! ((strcmp(argv[2], "lang=python") == 0)
|| (strcmp(argv[2], "lang=r") == 0)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need don't need r here, however, we need to do something similar in slc-release

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@tomuben tomuben merged commit cd4407a into master Apr 20, 2026
118 checks passed
@tomuben tomuben deleted the refactoring/1442_add_new_preprocessor_flag_use_static_swig branch April 20, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants