Skip to content

Feature/pmi 66 initial statment builder #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 1, 2018
Merged

Feature/pmi 66 initial statment builder #1

merged 15 commits into from
Oct 1, 2018

Conversation

@redcatbear
Copy link
Collaborator

@redcatbear redcatbear commented Sep 27, 2018

Initial merge to develop:

  • SELECT, FROM, JOIN (various types), WHERE, basic boolean expressions.
  • basic Travis CI
  • full test coverage

@redcatbear
PMI-66: Initial statement builder.
55f7754
@redcatbear
PMI-66: Added basic FROM clause.
3a5ecbf
@redcatbear
PMI-66: Support basic JOIN
e6fee55
@redcatbear
PMI-66: Experiment with sub-visitors
64191cb
@redcatbear
PMI-66: Removed duplication in tree handling. Improved renderer for b…
f02cf63 
…oolean expressions.
@redcatbear
PMI-66: Basic boolean expression handling complete.
02504d0
@redcatbear
PMI-66: Imporved test coverage.
047e229
@redcatbear
PMI-66: Raised test coverage to 100%.
544501c
@redcatbear
PMI-86: LIMIT clause now supports both count and offset.
556c92a
@redcatbear
PMI-86: Simplified double linking.
a793f90
@redcatbear
PMI-86: Added test coverage for LIMIT.
ec275e6
@redcatbear
PMI-86: Added lauch configuration for "mvn package"
dd77570
@redcatbear
PMI-86: Added build configuration for Travis CI.
6b6b54e
@redcatbear
PMI-86: Corrected indentation of "grep" in .travis.yml
eca869e
@redcatbear
PMI-86: Added Travis CI badge. Outlined milestone plan.
2635239
@morazow
Copy link
Contributor

morazow commented Sep 29, 2018

Hello @redcatbear ,
I did check the PR. It was very well understandable from my side. All essential building blocks were clear to me.

I give a try to build a where clause using BooleanExpression & BooleanExpressionRenderer in the future.

Best

@redcatbear
Copy link
Collaborator Author

redcatbear commented Sep 29, 2018

Hi @morazow, thanks for the review. Could you please approve the PR, so that I can merge it to the develop branch?

@morazow morazow self-requested a review September 30, 2018 10:51
@morazow
Copy link
Contributor

morazow commented Sep 30, 2018

@redcatbear done!

@redcatbear redcatbear merged commit fff45db into develop Oct 1, 2018
@redcatbear redcatbear deleted the feature/PMI-66_initial_statment_builder branch October 1, 2018 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@morazow morazow morazow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@redcatbear @morazow