PMI-97: Convert and parse INTERVALS. #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobkodex
approved these changes
Oct 16, 2018
doc/system_requirements.md
Outdated
| * Asterisk ("*") | ||
| Rationale: | ||
|
|
||
| Neighboring systems of an Exasol database often do to have equivalent data types, so conversion to a primitive data type is required. |
There was a problem hiding this comment.
... do to have equivalent
This section is unclear
Collaborator
Author
There was a problem hiding this comment.
Fixed:
"... do not have ..."
| * <li>milliseconds (or fraction of seconds)</li> | ||
| * </ul> | ||
| * | ||
| * Since milliseconds are the highest resolution, each interval can also be expresses as a total number of milliseconds. |
doc/design.md
Outdated
|
|
||
| The data converter can parse `INTERVAL DAY TO SECOND` from strings in the following format: | ||
|
|
||
| inverval-d2s = [ days SP ] hours ":" minutes [ ":" seconds [ "." milliseconds ] ] |
There was a problem hiding this comment.
typo: inverval-d2s --> interval-d2s
At first glance, notation is not completely clear.
Maybe concret examples for string intervals (interval-d2s, hours, minutes ...) could be helpul (just suggestion)
Collaborator
Author
There was a problem hiding this comment.
Added examples. Will add introduction including ABNF mention in separate ticket.
bobkodex
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: