ci(deps): Bump actions/download-artifact from 4 to 8#4
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
exbuf
added a commit
that referenced
this pull request
Jul 1, 2026
The save path (_mixin_data.py:1062) stores `"expression": True/False`
as a boolean flag; the actual expression string lives in
`search_text`. Three consumer paths (cli.py:1716, api.py:519,
_mixin_tools.py:6336) treated the boolean AS the expression:
expr = params.get("expression") if params.get("expression") else None
That set expr = True, which got passed to api_search's expression=
kwarg, which then raised inside expr_parser.tokenize():
File "/peekdocs/expr_parser.py", line 87, in tokenize
if not expression or not expression.strip():
AttributeError: 'bool' object has no attribute 'strip'
Reported symptom: Quarterly Content Audit suite (which has two
expression-mode saved searches) runs the first 3 searches fine,
crashes at search #4, no report ever written, GUI status stuck at
"Writing reports…" forever because the worker thread died silently.
Not caused by the 1.2.43 cloud-guard threading bug — the
Claude-DocSearch samples folder isn't cloud-synced, so the modal
would never have fired even in 1.2.49. That threading fix (82c2b0f)
is still correct and stays in — this crash was a separate bug
riding underneath it.
Fix pattern at all three sites: three-way branch on the mode
(expression / regex-wildcard / plain text) rather than a two-way
branch plus a broken expression extraction:
if params.get("expression"):
search_terms = []
expr = terms_str or None
elif params.get("regex") or params.get("wildcard"):
search_terms = [terms_str] if terms_str else []
expr = None
else:
# shlex-split for quoted phrases
...
expr = None
Repro'd from CLI: `peekdocs --suite "Quarterly content audit"`
crashed on 1.2.50, completes cleanly with 102 total matches
across 6 searches after the fix. 678 tests passing.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
exbuf
added a commit
that referenced
this pull request
Jul 1, 2026
Bug-fix release for expression-mode saved searches in suites (8039949). Reported by the user filming the Quarterly Content Audit demo — searches 1-3 finished, search #4 (expression mode) silently crashed, suite hung at "Writing reports…" forever. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/download-artifact from 4 to 8.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
3e5f45bAdd regression tests for CJK characters (#471)e6d03f6Add a regression test for artifact name + content-type mismatches (#472)70fc10cMerge pull request #461 from actions/danwkennedy/digest-mismatch-behaviorf258da9Add change docsccc058eFix linting issuesbd7976bAdd a setting to specify what to do on hash mismatch and default it toerrorac21fcfMerge pull request #460 from actions/danwkennedy/download-no-unzip15999bfAdd note about package bumps974686eBump the version tov8and add release notesfbe48b1Update test names to make it clearer what they doDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)