This repository was archived by the owner on Apr 6, 2024. It is now read-only.
chore: Upgrade all deps for Node 12 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ts:themeDefaultstepNotes
This includes support for Jest 26, needed for #29. Also it feels good to be up-to-date.
For posterity: we fork typedoc-default-theme. It was pretty out-of-date, using ts 2.8. I upgraded to grunt-ts 6 beta and switched to using a
tsconfig.jsonat the root. The issue was that TS will by default look up@typesin any "visible"node_modulesfolders so it was looking above intoexcalibur/node_modules/@typeswhich wasn't really compatible with TS 2.8 (syntax errors).By using
typeRootsin the tsconfig in this commit: excaliburjs/typedoc-default-themes@6ac5b41 it scopes TS to only look for types in the theme directory, not any above it that could conflict.