Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/doc/worksheet.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,10 @@ class Worksheet {
this.workbook.definedNames.spliceColumns(this.name, start, count, inserts.length);
}

get lastColumn() {
return this.getColumn(this.columnCount);
}

get columnCount() {
let maxCount = 0;
this.eachRow(row => {
Expand Down
3 changes: 3 additions & 0 deletions spec/integration/gold.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ describe('Gold Book', () => {
hyperlink: 'https://www.npmjs.com/package/exceljs',
text: 'exceljs',
});

expect(ws.lastColumn).to.equal(ws.getColumn(2));
expect(ws.lastRow).to.equal(ws.getRow(6));
});

it('Styles', () => {});
Expand Down
14 changes: 14 additions & 0 deletions spec/integration/pr/test-pr-1487.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
const ExcelJS = verquire('exceljs');

describe('github issues', () => {
describe('pull request 1487 - lastColumn with an empty column', () => {
it('Reading 1904.xlsx', () => {
const wb = new ExcelJS.Workbook();
return wb.xlsx.readFile('./spec/integration/data/1904.xlsx').then(() => {
const ws = wb.getWorksheet('Sheet1');
expect(ws.lastColumn).to.equal(ws.getColumn(2));
});
});
});
// the new property is also tested in gold.spec.js
});