Skip to content

Remove exception throwing from clients#56

Merged
pc9795 merged 2 commits intomainfrom
remove-exception-throwing-from-clients
May 20, 2021
Merged

Remove exception throwing from clients#56
pc9795 merged 2 commits intomainfrom
remove-exception-throwing-from-clients

Conversation

@pc9795
Copy link
Copy Markdown
Collaborator

@pc9795 pc9795 commented Apr 25, 2021

Ref:

Throwing errors.
We typically return a model from the submission client to give the status (again not required), we do this because we don't want to throw exceptions that might go unhandled. Our goals in the client is to never blow up a clients application ever, just log out a failure happened. Would be good to ensure we are ensuring the exceptions we do throw are caught at the call sites.

@pc9795 pc9795 mentioned this pull request Apr 25, 2021
@pc9795 pc9795 requested a review from niemyjski April 25, 2021 10:35
@pc9795 pc9795 merged commit b63731c into main May 20, 2021
@pc9795 pc9795 deleted the remove-exception-throwing-from-clients branch June 3, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants