Skip to content

fix construction of ExceptionlessClient#43

Merged
niemyjski merged 1 commit intoexceptionless:masterfrom
csantero:client-constructor
Apr 4, 2016
Merged

fix construction of ExceptionlessClient#43
niemyjski merged 1 commit intoexceptionless:masterfrom
csantero:client-constructor

Conversation

@csantero
Copy link
Contributor

@csantero csantero commented Apr 4, 2016

According to the readme, you should be able to instantiate an ExceptionlessClient like so:

var client = new exceptionless.ExceptionlessClient('API_KEY_HERE');
// or with an api key and server url
var client = new exceptionless.ExceptionlessClient('API_KEY_HERE', 'http://localhost:50000');
// or with a configuration object
var client = new exceptionless.ExceptionlessClient({
  apiKey: 'API_KEY_HERE',
  serverUrl: 'http://localhost:50000',
  submissionBatchSize: 100
});

As far as I can tell, these constructor arguments don't actually work as-is, due to a flipped equality comparison in the constructor.

@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@niemyjski
Copy link
Member

Awesome thank you! It looks like the lint task failed, could you please take a look into this.

@csantero csantero force-pushed the client-constructor branch from 40e5c81 to 8633db8 Compare April 4, 2016 21:38
@csantero
Copy link
Contributor Author

csantero commented Apr 4, 2016

@niemyjski Sorry about that... should be good now.

@niemyjski niemyjski merged commit 24dcd70 into exceptionless:master Apr 4, 2016
@niemyjski
Copy link
Member

Thanks!

@csantero csantero deleted the client-constructor branch April 4, 2016 21:44
@niemyjski
Copy link
Member

Do you need a release for this change?

@csantero
Copy link
Contributor Author

csantero commented Apr 4, 2016

@niemyjski Nah... it's easy enough to work around this bug by setting client.config.apiKey = ... after constructing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants