fix construction of ExceptionlessClient#43
Merged
niemyjski merged 1 commit intoexceptionless:masterfrom Apr 4, 2016
Merged
Conversation
Member
|
Awesome thank you! It looks like the lint task failed, could you please take a look into this. |
40e5c81 to
8633db8
Compare
Contributor
Author
|
@niemyjski Sorry about that... should be good now. |
Member
|
Thanks! |
Member
|
Do you need a release for this change? |
Contributor
Author
|
@niemyjski Nah... it's easy enough to work around this bug by setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the readme, you should be able to instantiate an ExceptionlessClient like so:
As far as I can tell, these constructor arguments don't actually work as-is, due to a flipped equality comparison in the constructor.