Always set up the interval for sending heartbeats.#51
Closed
Conversation
…ats when user identity is unknown
| if (user && user.identity) { | ||
| context.client.submitSessionHeartbeat(user.identity); | ||
| } | ||
| }, this._interval); |
Member
There was a problem hiding this comment.
I don't think this would solve the issue as the plugin would still have to be triggered by an event submission, and it would be good if that first submission had some kind of session id or user id so we could create a session server side.
in the .net client we have an internal session identifier that could make this simpler but the problem would still be there.
Please get a hold of me on slack and we'll talk through your scenario some more.
Contributor
Author
|
We're gonna have another go at simplifying this, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always set up the interval for sending heartbeats. Don't send heartbeats when user identity is unknown