Skip to content

🐛 FIX encoded URL ID references#715

Merged
chrisjsewell merged 1 commit intomasterfrom
fix-link-id
Feb 22, 2023
Merged

🐛 FIX encoded URL ID references#715
chrisjsewell merged 1 commit intomasterfrom
fix-link-id

Conversation

@chrisjsewell
Copy link
Copy Markdown
Member

@chrisjsewell chrisjsewell commented Feb 22, 2023

For example <#name with spaces> will be encoded as #name%20with%20spaces, so we need to decode before resolving the reference.

For example `<#name with spaces>` will be encoded as `name%20with%20spaces`,
so we need to decode before resolving the reference.
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2023

Codecov Report

Base: 89.36% // Head: 89.40% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (b75636b) compared to base (4cac732).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   89.36%   89.40%   +0.03%     
==========================================
  Files          23       23              
  Lines        2867     2868       +1     
==========================================
+ Hits         2562     2564       +2     
+ Misses        305      304       -1     
Flag Coverage Δ
pytests 89.40% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/mdit_to_docutils/base.py 92.88% <100.00%> (ø)
myst_parser/mdit_to_docutils/transforms.py 86.84% <100.00%> (+1.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrisjsewell chrisjsewell merged commit 2902e07 into master Feb 22, 2023
@chrisjsewell chrisjsewell deleted the fix-link-id branch February 22, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant