👌 Improve [](#target) resolution warnings#716
Merged
chrisjsewell merged 1 commit intomasterfrom Feb 22, 2023
Merged
Conversation
# references[](#target) resolution warnings
Codecov ReportBase: 89.40% // Head: 89.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 89.40% 89.80% +0.40%
==========================================
Files 23 23
Lines 2868 2883 +15
==========================================
+ Hits 2564 2589 +25
+ Misses 304 294 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if
[](#target)matched nothing locally, but multiple items in intersphinx inventories, then no warning would be logged, and the first match silently used.Resolution of intersphinx now proceeds (if no local matches found) the same as for
[](inv:#target), such that amyst.iref_ambiguouswarning is emitted in this case (the first match is then still used).Warnings coming from resolution of
[](#target)can also now be "individually" turned off using https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-nitpick_ignore, e.g.nitpick_ignore = [("myst", "target")]