Skip to content

Conversation

@hukkin
Copy link
Contributor

@hukkin hukkin commented Jan 6, 2021

It seems NestedTokens represents a _open token and _close token pair and the tokens in the stream between them. I think closing token should not be optional?

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #118 (0f49cd7) into master (2afb7cc) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   96.42%   96.38%   -0.04%     
==========================================
  Files          69       69              
  Lines        2934     2932       -2     
==========================================
- Hits         2829     2826       -3     
- Misses        105      106       +1     
Flag Coverage Δ
pytests 96.38% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/token.py 91.76% <100.00%> (ø)
markdown_it/cli/parse.py 85.41% <0.00%> (-2.59%) ⬇️
markdown_it/rules_block/table.py 98.51% <0.00%> (-0.03%) ⬇️
markdown_it/rules_block/blockquote.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afb7cc...6dc041b. Read the comment docs.

@hukkin hukkin changed the title Make NestedTokens.closing not optional 👌 IMPROVE: Make NestedTokens.closing not optional Jan 7, 2021
@chrisjsewell chrisjsewell merged commit 031b329 into executablebooks:master Feb 25, 2021
@hukkin hukkin deleted the strict-nestedtokens-typing branch March 9, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants