Skip to content

👌 IMPROVE: Make NestedTokens.closing not optional #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2021
Merged

👌 IMPROVE: Make NestedTokens.closing not optional #118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fd0b39
Make `NestedTokens.closing` not optional
hukkinj1 Jan 6, 2021
64527c8
Explain "type: ignore"
hukkinj1 Jan 7, 2021
6dc041b
Merge branch 'master' into strict-nestedtokens-typing
chrisjsewell Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion markdown_it/token.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class NestedTokens:
"""

opening: Token = attr.ib()
closing: Optional[Token] = attr.ib()
closing: Token = attr.ib()
children: List[Union[Token, "NestedTokens"]] = attr.ib(factory=list)

def __getattr__(self, name):
Expand All @@ -144,6 +144,9 @@ def nest_tokens(tokens: List[Token]) -> List[Union[Token, NestedTokens]]:
token = token.copy()
output.append(token)
if token.children:
# Ignore type checkers because `nest_tokens` doesn't respect
# typing of `Token.children`. We add `NestedTokens` into a
# `List[Token]` here.
token.children = nest_tokens(token.children) # type: ignore
continue

Expand Down