Skip to content

Conversation

@hukkin
Copy link
Contributor

@hukkin hukkin commented Feb 25, 2021

Realized I can not subclass and add methods to the tree class, because it always instantiates the base class. This fixes it

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #130 (124da6c) into master (888636c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          72       72           
  Lines        3104     3104           
=======================================
  Hits         2986     2986           
  Misses        118      118           
Flag Coverage Δ
pytests 96.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/tree.py 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888636c...124da6c. Read the comment docs.

@chrisjsewell
Copy link
Member

👍

@chrisjsewell chrisjsewell merged commit 261dc90 into executablebooks:master Feb 25, 2021
@hukkin hukkin deleted the subclassable-syntaxtree branch March 9, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants