Skip to content

👌 IMPROVE: Make SyntaxTreeNode subclassable #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2021
Merged

👌 IMPROVE: Make SyntaxTreeNode subclassable #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions markdown_it/tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ def __init__(self) -> None:
# children (i.e. inline or img)
self.children: List["SyntaxTreeNode"] = []

@staticmethod
def from_tokens(tokens: Sequence[Token]) -> "SyntaxTreeNode":
@classmethod
def from_tokens(cls, tokens: Sequence[Token]) -> "SyntaxTreeNode":
"""Instantiate a `SyntaxTreeNode` from a token stream.

This is the standard method for instantiating `SyntaxTreeNode`.
"""
root = SyntaxTreeNode()
root = cls()
root._set_children_from_tokens(tokens)
return root

Expand Down Expand Up @@ -143,7 +143,7 @@ def _make_child(
"""Make and return a child node for `self`."""
if token and nester_tokens or not token and not nester_tokens:
raise ValueError("must specify either `token` or `nester_tokens`")
child = SyntaxTreeNode()
child = type(self)()
if token:
child.token = token
else:
Expand Down