Skip to content

Conversation

@tsutsu3
Copy link
Contributor

@tsutsu3 tsutsu3 commented Oct 31, 2020

#5

Summary

Ported smartquotes.js

Changed

  • Add two test cases that were updated in the js ver.
  • Changed the test case from <br> to <br /> to match the default commonmark preset

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #67 into master will increase coverage by 0.09%.
The diff coverage is 98.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   95.31%   95.40%   +0.09%     
==========================================
  Files          74       75       +1     
  Lines        3627     3745     +118     
==========================================
+ Hits         3457     3573     +116     
- Misses        170      172       +2     
Flag Coverage Δ
pytests 95.40% <98.31%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/rules_core/smartquotes.py 98.29% <98.29%> (ø)
markdown_it/parser_core.py 100.00% <100.00%> (ø)
markdown_it/rules_core/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7783a37...a808a73. Read the comment docs.

@tsutsu3 tsutsu3 marked this pull request as ready for review October 31, 2020 07:17
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thanks!

@chrisjsewell chrisjsewell changed the title [ENH] Add smartquotes ✨ NEW: Add smartquotes Oct 31, 2020
@chrisjsewell chrisjsewell merged commit 510e2bf into executablebooks:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants