‼️ BREAKING: drop Python 3.8 #42
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR drops support for Python 3.8 as a breaking change, updating the minimum required Python version to 3.9 and adding support for newer Python versions.
- Updates minimum Python version requirement from 3.7 to 3.9
- Adds support for Python 3.11, 3.13, and development version 3.14
- Updates CI/CD configuration to test against new Python versions and adds macOS testing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updates minimum Python version requirement and removes upper bound on mdformat dependency |
| tox.ini | Updates test environments to use Python 3.9, 3.11, and 3.13 instead of 3.7 and 3.8 |
| .github/workflows/tests.yml | Updates CI matrix to test Python 3.9, 3.13, 3.14-dev and adds macOS runner |
| mdformat_myst/py.typed | Adds PEP 561 marker file for type information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| requires-python=">=3.9" | ||
| requires=[ | ||
| "mdformat >=0.7.0,<0.8.0", | ||
| "mdformat >=0.7.0", |
There was a problem hiding this comment.
We shouldn't need to pin mdformat because a breaking change may not impact this package
|
I'm going to go ahead and merge because the changes are minimal and CI passes. We can fix forward on any issues or concerns |
|
Released with 0.2.2, but should likely have been 0.3.0 because of the (partially) breaking change by dropping Python support |
| push: | ||
| branches: [ master ] | ||
| tags: [ '*.*.*' ] | ||
| tags: [ '[0-9]+.[0-9]+.[0-9]+*' ] |
There was a problem hiding this comment.
For consistency with mdformat, the format of v#.#.# is no longer supported and #.#.# should be used instead. However, this might cause more confusion because of how previous tags were labeled
Fix #41