Skip to content

‼️ BREAKING: drop Python 3.8 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

‼️ BREAKING: drop Python 3.8 #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Tests
on:
push:
branches: [ master ]
tags: [ '*.*.*' ]
tags: [ '[0-9]+.[0-9]+.[0-9]+*' ]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with mdformat, the format of v#.#.# is no longer supported and #.#.# should be used instead. However, this might cause more confusion because of how previous tags were labeled

pull_request:
branches: [ master ]

Expand All @@ -24,8 +24,9 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: [3.7, 3.11]
os: [ubuntu-latest, windows-latest]
python-version: ['3.9', '3.13', '3.14-dev']
os: [ubuntu-latest, macos-latest, windows-latest]
continue-on-error: ${{ matrix.python-version == '3.14-dev' }}

steps:
- uses: actions/checkout@v4
Expand All @@ -48,7 +49,7 @@ jobs:

# FYI: Requires token to continue usage
# - name: Upload to Codecov
# if: matrix.os == 'ubuntu-latest' && matrix.python-version == 3.8
# if: matrix.os == 'ubuntu-latest' && matrix.python-version == 3.9
# uses: codecov/codecov-action@v1
# with:
# name: pytests
Expand All @@ -64,7 +65,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.8
python-version: 3.9

- name: Installation (deps and package)
run: |
Expand All @@ -86,7 +87,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9
- name: install flit
run: |
pip install flit~=3.0
Expand Down
1 change: 1 addition & 0 deletions mdformat_myst/py.typed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Marker file for PEP 561
5 changes: 2 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
requires = ["flit_core >=2,<4"]
build-backend = "flit_core.buildapi"


[tool.flit.metadata]
module = "mdformat_myst"
author = "Taneli Hukkinen"
Expand All @@ -19,9 +18,9 @@ classifiers = [
]
keywords = "mdformat,markdown,formatter,gfm"

requires-python=">=3.7"
requires-python=">=3.9"
requires=[
"mdformat >=0.7.0,<0.8.0",
"mdformat >=0.7.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to pin mdformat because a breaking change may not impact this package

"mdit-py-plugins >=0.3.0",
"mdformat-tables >=0.4.0",
"mdformat-frontmatter >=0.3.2",
Expand Down
6 changes: 3 additions & 3 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
[tox]
envlist = py38
envlist = py39
isolated_build = True

[testenv:py{37,38,39}]
[testenv:py{39,311,313}]
extras = test
deps =
black
flake8
commands = pytest {posargs}

[testenv:py{37,38,39}-hook]
[testenv:py{39,311,313}-hook]
commands = pre-commit run --config .pre-commit-test.yaml {posargs:--all-files --verbose --show-diff-on-failure}

[flake8]
Expand Down
Loading