[FIX,TST] Fix math label in proof directive#11
Merged
Conversation
Member
|
Nice work @najuzilu. This is your project so feel free to merge when you feel ready. @AakashGfude is currently running some further tests now if you'd like any verification etc. |
Member
|
Thanks @najuzilu , looking good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
list index out of rangeerror thrown when aproof:proofdirective includes amathdirective with a label (#2).New test cases have been included:
proof:proofdirective which includes a labeledmathdirectiveproof:proofdirective which includes amathdirective (no label)proof:proofdirective that require no argumentsIn addition to that,
nodes.emphasis()has been replaced with the CSS font-style.