Skip to content

[FIX,TST] Fix math label in proof directive#11

Merged
najuzilu merged 3 commits intomasterfrom
fix-proof-math-label
Aug 31, 2020
Merged

[FIX,TST] Fix math label in proof directive#11
najuzilu merged 3 commits intomasterfrom
fix-proof-math-label

Conversation

@najuzilu
Copy link
Copy Markdown
Member

This PR fixes the list index out of range error thrown when a proof:proof directive includes a math directive with a label (#2).

New test cases have been included:

  • _proof_with_labeled_math: example of proof:proof directive which includes a labeled math directive
  • _proof_with_labeled_math: simple example of proof:proof directive which includes a math directive (no label)
  • _proof_with_argument_content: example of a proof:proof directive that require no arguments

In addition to that, nodes.emphasis() has been replaced with the CSS font-style.

@mmcky
Copy link
Copy Markdown
Member

mmcky commented Aug 31, 2020

Nice work @najuzilu.

This is your project so feel free to merge when you feel ready. @AakashGfude is currently running some further tests now if you'd like any verification etc.

@najuzilu najuzilu merged commit 137dfd4 into master Aug 31, 2020
@AakashGfude
Copy link
Copy Markdown
Member

Thanks @najuzilu , looking good.

@najuzilu najuzilu deleted the fix-proof-math-label branch September 1, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants