Skip to content

Conversation

@MPenaR
Copy link

@MPenaR MPenaR commented Nov 10, 2024

Spanish translations working

@MPenaR
Copy link
Author

MPenaR commented Nov 11, 2024

Merged the cross-reference code from @dtenbrinck and also performed the tox test with output:

============================================================================== warnings summary ==============================================================================
tests/conftest.py:4
  /home/manuel/Documentos/sphinx-proof/tests/conftest.py:4: RemovedInSphinx90Warning: 'sphinx.testing.path' is deprecated. Use 'os.path' or 'pathlib' instead.
    from sphinx.testing.path import path

tests/test_html.py::test_missing_ref
  /home/manuel/Documentos/sphinx-proof/.tox/py311-sphinx5/lib/python3.11/site-packages/sphinx_proof/domain.py:149: RemovedInSphinx90Warning: Sphinx 9 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.
    path = self.env.doc2path(fromdocname)[:-3]

tests/test_html.py::test_duplicate_label
  /home/manuel/Documentos/sphinx-proof/.tox/py311-sphinx5/lib/python3.11/site-packages/sphinx_proof/directive.py:62: RemovedInSphinx90Warning: Sphinx 9 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.
    path = env.doc2path(env.docname)[:-3]

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================================= 15 passed, 3 warnings in 1.51s =======================================================================
  py311-sphinx5: OK (3.66=setup[1.76]+cmd[1.90] seconds)
  congratulations :) (3.72 seconds)

Copy link

@tiagox tiagox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MPenaR, I've just left a suggestion on one of your translations.

For the maintainer's team. I'd love to see this included in the library. Please prioritize this PR.

@@ -1,2 +1 @@
[{"language":"English","symbol":"en","text":"Remark"},{"language":"Arabic","symbol":"ar","text":"ملاحظة"},{"language":"Dutch","symbol":"nl","text":"Opmerking"},{"language":"French","symbol":"fr","text":"Remarque"},{"language":"German","symbol":"de","text":"Anmerkung"},{"language":"Italian","symbol":"it","text":"osservazione"},{"language":"Japanese","symbol":"ja","text":"述べる"},{"language":"Russian","symbol":"ru","text":"Замечание"},{"language":"Spanish","symbol":"es","text":"Observación"},
{"language":"Czech","symbol":"cs","text":"Poznámka"}]
[{"language":"English","symbol":"en","text":"Remark"},{"language":"Arabic","symbol":"ar","text":"ملاحظة"},{"language":"Dutch","symbol":"nl","text":"Opmerking"},{"language":"French","symbol":"fr","text":"Remarque"},{"language":"German","symbol":"de","text":"Bemerkung"},{"language":"Italian","symbol":"it","text":"osservazione"},{"language":"Japanese","symbol":"ja","text":"述べる"},{"language":"Russian","symbol":"ru","text":"Замечание"},{"language":"Spanish","symbol":"es","text":"Nota"},{"language":"Czech","symbol":"cs","text":"Poznámka"}]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For spanish, I'd suggest to translate "remark" as "observación" instead of "nota".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I think the main reason they don't include this kind of PR is the variability of interpretations on the "good translation".

Don't get me wrong, I prefer your translation to "Observación" than mine

mmcky added a commit that referenced this pull request Mar 11, 2025
mmcky added a commit that referenced this pull request Mar 11, 2025
* re-order json files

* migrate dutch translations from #120

* migrate translations from #127

* migrate translations from #138

* add support for corollary

* enable translation of title

* add note to internationalization page
@mmcky
Copy link
Member

mmcky commented Mar 11, 2025

thank you @MPenaR for this contribution, greatly appreciated.

I have done a full maintenance round in #138 and incorporated your translations. I will update the release notes to incorporate your contribution as we really value input and contributions like this.

@mmcky mmcky closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants