-
Notifications
You must be signed in to change notification settings - Fork 22
Spanish translations #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanish translations #127
Conversation
for more information, see https://pre-commit.ci
…o 'Nota' so 'Observation' can be 'Observación', and corrected the translation of 'Theorem' to 'Teorema'
|
Merged the cross-reference code from @dtenbrinck and also performed the tox test with output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MPenaR, I've just left a suggestion on one of your translations.
For the maintainer's team. I'd love to see this included in the library. Please prioritize this PR.
| @@ -1,2 +1 @@ | |||
| [{"language":"English","symbol":"en","text":"Remark"},{"language":"Arabic","symbol":"ar","text":"ملاحظة"},{"language":"Dutch","symbol":"nl","text":"Opmerking"},{"language":"French","symbol":"fr","text":"Remarque"},{"language":"German","symbol":"de","text":"Anmerkung"},{"language":"Italian","symbol":"it","text":"osservazione"},{"language":"Japanese","symbol":"ja","text":"述べる"},{"language":"Russian","symbol":"ru","text":"Замечание"},{"language":"Spanish","symbol":"es","text":"Observación"}, | |||
| {"language":"Czech","symbol":"cs","text":"Poznámka"}] | |||
| [{"language":"English","symbol":"en","text":"Remark"},{"language":"Arabic","symbol":"ar","text":"ملاحظة"},{"language":"Dutch","symbol":"nl","text":"Opmerking"},{"language":"French","symbol":"fr","text":"Remarque"},{"language":"German","symbol":"de","text":"Bemerkung"},{"language":"Italian","symbol":"it","text":"osservazione"},{"language":"Japanese","symbol":"ja","text":"述べる"},{"language":"Russian","symbol":"ru","text":"Замечание"},{"language":"Spanish","symbol":"es","text":"Nota"},{"language":"Czech","symbol":"cs","text":"Poznámka"}] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For spanish, I'd suggest to translate "remark" as "observación" instead of "nota".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I think the main reason they don't include this kind of PR is the variability of interpretations on the "good translation".
Don't get me wrong, I prefer your translation to "Observación" than mine
Spanish translations working