📚 DOCS:: Update for dropdown class #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I was trying to use this extension, and got confused because the readme wasn't updated for the new `dropdown` class and `toggle-shown` semantics (as opposed to being shown by default with toggle-hidden as an option). Ref: 8cebb39, executablebooks#13 - I fixed it to save others some time, since this took quite a while to figure out... - Review: make sure it's correct, I didn't miss anywhere, this is what the future is. - also fix the "container" part at the bottom - should this be updated to the toggle directive or is that still true?
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
this looks great, thanks for catching this @rkdarst :-) |
choldgraf
changed the title
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme wasn't updated for the new
dropdownclass andtoggle-shownsemantics (as opposed to being shown by default withtoggle-hidden as an option). Ref: 8cebb39, using classes for admonition toggles #13
to figure out...
the future is.
updated to the toggle directive or is that still true?