Link to .elpx is not working

[ignaciogros]

In addition to the iDevice for downloading the .elpx file, users can create a link to the file itself:

<a href="exe-package:elp" id="link_0" download="exe-package:elp-name">Download file</a>

A link to exe-package:elp is a link to the .elpx file, and those links are not working now.

fflate.umd.js and exe_elpx_download.js should be exported in those cases too.

Example

[erseco]

Problem Summary

Manual links using exe-package:elp protocol (created in text iDevices) are not working because the required
JavaScript libraries (fflate.umd.js and exe_elpx_download.js) are not included in the export.

Root Cause: The detection logic only looks for:

1. iDevice type containing download-source-file
2. CSS class exe-download-package-link

But manual links created in text iDevices have neither - they only have href="exe-package:elp" protocol.

Evidence from example ZIP:

• The link IS correctly transformed to onclick="if(typeof downloadElpx==='function')downloadElpx();return false;"
• BUT libs/fflate/ and libs/exe_elpx_download/ are NOT present in the export
• Therefore downloadElpx function is undefined and clicking does nothing

Files to Modify

1. src/shared/export/exporters/BaseExporter.ts

Location: Lines 654-669 (pageHasDownloadSourceFile method)

Change: Add detection for exe-package:elp protocol in content

 protected pageHasDownloadSourceFile(page: ExportPage): boolean {
     for (const block of page.blocks || []) {
         for (const component of block.components || []) {
             // Check by iDevice type
             const type = (component.type || '').toLowerCase();
             if (type.includes('download-source-file') || type.includes('downloadsourcefile')) {
                 return true;
             }
             // Check content for the CSS class (download-source-file iDevice)
             if (component.content?.includes('exe-download-package-link')) {
                 return true;
             }
             // Check for manual exe-package:elp links (in text iDevices, etc.)
             if (component.content?.includes('exe-package:elp')) {
                 return true;
             }
         }
     }
     return false;
 }

2. src/shared/export/constants.ts

Location: Lines 303-310 (LIBRARY_PATTERNS for exe_elpx_download)

Change: Add a second detection pattern using type: 'regex' for the exe-package:elp protocol

 // ELPX download support (for download-source-file iDevice)
 // Includes fflate for client-side ZIP generation
 {
     name: 'exe_elpx_download',
     type: 'class',
     pattern: 'exe-download-package-link',
     files: ['fflate/fflate.umd.js', 'exe_elpx_download/exe_elpx_download.js'],
 },
 // ELPX download support for manual links using exe-package:elp protocol
 {
     name: 'exe_elpx_download_protocol',
     type: 'regex',
     pattern: /exe-package:elp/,
     files: ['fflate/fflate.umd.js', 'exe_elpx_download/exe_elpx_download.js'],
 },

LibraryDetector already supports type: 'regex' (line 113-115 in LibraryDetector.ts).

Verification

1. Run existing tests:
   make test-unit
2. Test with the example file:

• Import /Users/ernesto/Downloads/download-elpx.zip or recreate a project with a manual exe-package:elp link in a
  text iDevice
• Export to HTML5
• Verify that libs/fflate/fflate.umd.js and libs/exe_elpx_download/exe_elpx_download.js are in the export
• Open the exported HTML and verify the download link works

3. Run integration tests for elpx-download:
   DB_PATH=:memory: ELYSIA_FILES_DIR=/tmp/exelearning-test bun test test/integration/export/elpx-download.spec.ts

Additional Considerations

• The fix should work for both HTML5 export and SCORM exports
• WebsitePreviewExporter handles this differently (uses postMessage) so preview should still work