Prevent issue-translator from running on PR comments#1477
Merged
eXeLearningProject merged 2 commits intomainfrom Mar 7, 2026
Merged
Prevent issue-translator from running on PR comments#1477eXeLearningProject merged 2 commits intomainfrom
eXeLearningProject merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1477 +/- ##
==========================================
- Coverage 90.54% 90.54% -0.01%
==========================================
Files 337 337
Lines 72116 72147 +31
==========================================
+ Hits 65295 65323 +28
- Misses 6821 6824 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bundle ReportBundle size has no change ✅ |
ignaciogros
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
issue-translatorGitHub Actions workflow is triggered byissue_commentevents. In GitHub, this event is fired for both issue comments and pull request comments.This currently causes two problems:
Resource not accessible by integrationbecause the workflow only hasissues: writepermission and notpull-requests: write.Changes
File:
.github/workflows/issue-translator.ymlThis PR introduces two small changes:
GitHub sets
github.event.issue.pull_requestwhen the comment belongs to a pull request. This ensures the workflow only runs for actual issue comments and issue creation events.cloudflare-workers-and-pages[bot]toSKIP_ACTORSto prevent translating deployment bot comments in the unlikely event they appear on issues.Verification
Validate that the workflow YAML is correct.
Confirm that
github.event.issue.pull_requestis:This ensures the workflow only runs where it is intended.