fix: stop shipping dev artefacts in make package ZIP (#50)#52
Merged
Conversation
2 tasks
`.claude`, `.omc`, `.editor-version`, `.env.dist` and the stray Windows `NUL` file were being picked up by `make package` because they were not listed in `.distignore`. Add them so they no longer end up in release ZIPs. Also document a `Twin-plugin checks` workflow in `AGENTS.md` requiring cross-checks against the sibling `mod_exescorm` repository whenever a fix is applied here.
erseco
force-pushed
the
50-no-unnecessary-files-in-package
branch
from
df9a711 to
b0a231c
Compare
ignaciogros
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #50.
.claude/,.omc/,.editor-version,.env.distand the stray WindowsNULfile were being copied into the release ZIP because they were not listed in.distignore. They are now excluded somake package RELEASE=X.Y.Zproduces a clean distribution.AGENTS.mdalso gains a Twin-plugin checks section that asks coding agents to verify whether the same bug reproduces onmod_exescormand to open a sibling PR when it does — that is what motivated the parallel fix below.What changed
.distignore: added.claude,.omc,.editor-version,.env.dist,NUL.AGENTS.md: new Twin-plugin checks (mod_exeweb ↔ mod_exescorm) section under Packaging & Release.Test plan
make package RELEASE=testproducesmod_exeweb-test.zip;unzip -lshows no.claude,.omc,.editor-version,.env*,NUL,.distignore, or.git*entries.amd/,classes/,lang/,dist/,lib.php,view.php, …) is still present and the ZIP installs cleanly via Moodle plugin install.Sibling PR
Same fix on the SCORM side: exelearning/mod_exescorm#67 (issue exelearning/mod_exescorm#65).
Moodle Playground Preview
The changes in this pull request can be previewed and tested using a Moodle Playground instance.