SED-4506 Clean-up of isolated AP resources delete all revisions and f…

[david-stephan]

…iles but keep the resource entry in DB

[gemini-code-assist]

Summary of Changes

Hello @david-stephan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the cleanup process for isolated automation package resources. The change ensures that when resources are deemed outdated, all their associated revisions and files are thoroughly deleted from the system, while the main resource entry in the database is intentionally retained. This improves resource management by preventing the accumulation of stale data and ensuring a cleaner state for managed packages.

Highlights

• Resource Cleanup Logic: The method for cleaning up outdated isolated automation package resources has been updated. Previously, only deleteResourceRevisionContent was called, but now deleteResource is used, indicating a more comprehensive removal of all revisions and associated files for the resource.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request changes the cleanup logic for outdated isolated automation package resources by replacing deleteResourceRevisionContent with deleteResource. My review highlights a critical issue: this change contradicts the pull request's description, which states that the resource entry should be kept in the database. The new code will remove the resource entry entirely. It's important to align the code with its intended behavior, so I've asked for clarification on whether the code or the description needs to be corrected.

[gemini-code-assist]

There is a contradiction between the pull request description and this code change. The description states to '...keep the resource entry in DB'. However, deleteResource removes the resource entry from the database, while the original deleteResourceRevisionContent did not.

Please clarify the intended behavior. If the resource entry should be deleted, the PR description should be updated to reflect this. If it should be kept, this change is incorrect.