fix(rss): retry curl on DNS failures when fetching news feeds#182
Merged
Conversation
curl's --retry does not retry on DNS resolution failures (exit code 6) by default, only on timeouts and HTTP errors. This causes intermittent "Cannot fetch news" errors when the local DNS resolver briefly fails. Add --retry-all-errors to retry on all transient errors including DNS, bump retries from 2 to 3, and add --retry-delay 1 for a 1-second pause between attempts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--retrydoes not retry on DNS resolution failures (exit code 6) by default — only on timeouts and HTTP errors. This causes intermittent "Cannot fetch news" errors on systems without a local DNS cache when the resolver briefly fails.--retry-all-errorsto the RSS feed curl call so it retries on all transient errors including DNS failures--retry-delay 1for a 1-second pause between attemptsContext
On systems using NetworkManager without
systemd-resolvedordnsmasq, there is no local DNS cache. Brief DNS resolver hiccups cause the RSS fetch to fail immediately with no retry, producing the "Cannot fetch news" error in the widget. With--retry-all-errors, curl will retry these transient DNS failures before giving up.🤖 Generated with Claude Code