Skip to content

Conversation

@aage
Copy link
Contributor

@aage aage commented Jul 17, 2023

No description provided.

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 17, 2023
Comment on lines +1 to +8
let distance (strand1: string) (strand2: string) : int option =
if strand1.Length <> strand2.Length
then None
else
[ for idx in 0 .. strand1.Length - 1 do
if strand1[idx] <> strand2[idx] then yield 1 else yield 0 ]
|> List.sum
|> Some No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to keep in mind: lines that are too long are clipped.

some measurements on my end
  • Desktop, overview page: room for 42 columns, clipped to 41 when longer.
  • Desktop, individual approach page: room for 36 columns, clipped to 35 when longer.
  • Phone, portrait, both pages: room for 30 columns, clipped to 29 when longer.
  • Phone, landscape, both pages: plenty of room.

@ErikSchierboom don't you think it would be better for the snippets to be horizontally scrollable rather than clipped?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. Please open an issue on the forum

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ErikSchierboom ErikSchierboom merged commit dd2c1d0 into exercism:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants