annalyns-infiltration

[A-Young-Git]

Instead of returning boolean literals after a condition, you can directly return the condition instead.

Example:

// instead of
if (knightIsAwake) {
return true;
} else {
return false;
}

// ... return the expression directly
return knightIsAwake;

THIS IS INCORRECT. If knightIsAwake = true, then we cannot do a fast attack (false)
If you were to return the direct condition, it will fail.

if knightIsAwake then we return true which is false
if !knightIsAwake then we return false which should be true that we CAN do a fast attack

[kahgoh]

I think the example comment is misleading. The example in the comment is meant to just be an example to say that if statements aren't needed, but it happens to be using knightIsAwake as an example. I'd suggest we update the example in the comment in the analyzer comment, perhaps using the wording from JavaScript track's comments.

[kahgoh]

Reopened the issue, as the close was accidental.

[kahgoh]

Closing this issue as exercism/website-copy#2356 has been merged.