Adding analyzer for log-levels concept exercise
#136
Conversation
sanderploegsma
left a comment
sanderploegsma
left a comment
There was a problem hiding this comment.
Overall it's looking very neat, nice work so far!
src/main/java/analyzer/exercises/loglevels/LogLevelsAnalyzer.java
Outdated
Show resolved
Hide resolved
src/main/java/analyzer/exercises/loglevels/UseSubstringMethod.java
Outdated
Show resolved
Hide resolved
src/main/java/analyzer/exercises/loglevels/UseSubstringMethod.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com>
Renaming comment of string format to prefer_string_concatenation Adding another helper method callsMethod Making comment about substrings general Adding another tests case for when substring is not being used in both methods Making the analyzer to return only the hardcode and substring method if those trigger, so we do not overload the student of comments
|
@sanderploegsma I've found that for hardcoded tests it was being used this general comment I should use this one? Or the one I created is ok? |
Great job for noticing, I forgot about that. If there is a general comment already, please use that instead of adding a new one! The only exception would be if you want the comment copy to contain more information that perhaps is exercise-specific, but I don't think that's the case here. |
src/main/java/analyzer/exercises/loglevels/DoNotHardcodeLogLevels.java
Outdated
Show resolved
Hide resolved
src/main/java/analyzer/exercises/loglevels/PreferStringConcatenation.java
Outdated
Show resolved
Hide resolved
Using general comment for hardcoded tests Updating prefer string concatenation comment to be a general one
|
@sanderploegsma I was thinking if we should also make this one a general comment ReuseCode if we are being vague with the lasagna one we can apply it to this one as well |
If you have a good idea for it then by all means! I suggest taking a look at the website copy first to see how it all works out. |
…a and log-levels analyzers
Great! mostly because I was thinking on future analyzers that could also use the reusecode comment, so for me it makes more sense to make it a general one! |
3 participants
closes #107
To do: