Implement analyzer for wizards-and-warriors #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderploegsma
requested changes
Mar 18, 2024
Contributor
sanderploegsma
left a comment
sanderploegsma
left a comment
There was a problem hiding this comment.
Overall looks good to me! One thing to address and a minor comment.
src/main/java/analyzer/exercises/wizardsandwarriors/WizardsAndWarriorsAnalyzer.java
Outdated
Show resolved
Hide resolved
src/main/java/analyzer/exercises/wizardsandwarriors/WizardsAndWarriorsAnalyzer.java
Outdated
Show resolved
Hide resolved
…ion more sophisticated Adding extra analyzer and scenario to test that
sanderploegsma
approved these changes
Mar 20, 2024
Contributor
Author
|
@ErikSchierboom Hey Erik! Can you please give us a hand with the review of this pr? Thanks! |
ErikSchierboom
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #115
Todo: