-
-
Notifications
You must be signed in to change notification settings - Fork 742
Fix Ledger test so they pass regardless of system locale
#2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sanderploegsma
merged 11 commits into
exercism:main
from
manumafe98:FixLedgerTestSoTheyPassRegardlessOfTheSystemLocale
Jan 23, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
717fd9e
Adding to the string format to always format using the Locale.US, so …
manumafe98 c186631
Adding junit-pioneer dependency, to use DefaultLocale to fix local te…
manumafe98 61913a4
Adding to the string format to always format using the Locale.US, so …
manumafe98 798b93f
Adding junit-pioneer dependency, to use DefaultLocale to fix local te…
manumafe98 b8ad3d3
Fixing conflict
manumafe98 1144dca
Merge branch 'main' into FixLedgerTestSoTheyPassRegardlessOfTheSystem…
sanderploegsma e1d61f8
Merge branch 'exercism:main' into FixLedgerTestSoTheyPassRegardlessOf…
manumafe98 3be7133
Adding LocaleExtension file to use extension context to change defaul…
manumafe98 31c3616
Fixing lint issue, and order of execution of the extension
manumafe98 f6499fc
Adding test file to config.json
manumafe98 85e99bb
Reverting build.gradle
manumafe98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
exercises/practice/ledger/src/test/java/LocaleExtension.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import org.junit.jupiter.api.extension.AfterTestExecutionCallback; | ||
| import org.junit.jupiter.api.extension.BeforeTestExecutionCallback; | ||
| import org.junit.jupiter.api.extension.ExtensionContext; | ||
|
|
||
| import java.util.Locale; | ||
|
|
||
| public class LocaleExtension implements BeforeTestExecutionCallback, AfterTestExecutionCallback { | ||
| private Locale originalLocale; | ||
|
|
||
| @Override | ||
| public void beforeTestExecution(ExtensionContext context) throws Exception { | ||
| originalLocale = Locale.getDefault(); | ||
|
|
||
| Locale.setDefault(Locale.US); | ||
| } | ||
|
|
||
| @Override | ||
| public void afterTestExecution(ExtensionContext context) throws Exception { | ||
| Locale.setDefault(originalLocale); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.