Skip to content

Conversation

@jagdish-15
Copy link
Member

@jagdish-15 jagdish-15 commented Jan 17, 2025

Pull Request: Update Test Suite for Palindrome-Products Exercise

This pull request updates the test suite for the Palindrome-Products exercise to align it with the latest problem specification.

Key Changes

  • The test suite now incorporates the updated cases from the latest specification.
  • The old proof solution has been replaced with the one published by @Cool-Katt, as the previous solution assumed the smallest product was always derived from the smallest factor—a scenario specifically addressed by the new test cases.
  • @Cool-Katt has been added to the contributors' list in acknowledgement of their solution contribution.

Please review the changes and let me know if further adjustments are needed.

@github-actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 17, 2025
@Cool-Katt Cool-Katt reopened this Jan 17, 2025
@Cool-Katt
Copy link
Contributor

@jagdish-15 was the old CI failing?

@jagdish-15
Copy link
Member Author

@Cool-Katt, yes, the old CL was failing, as explained above!

@Cool-Katt Cool-Katt merged commit a3a8df0 into exercism:main Jan 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants