Skip to content

Conversation

@FFFF-0000h
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 1, 2025
@SleeplessByte SleeplessByte reopened this Oct 1, 2025
@SleeplessByte
Copy link
Member

Forum post here: https://forum.exercism.org/t/clarity-on-template-strings/19454/2

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because word-wrap can be on and you can compose strings over multiple lines using +, I rather say regular as opposed to template, instead of single-line. WDYT?

@FFFF-0000h
Copy link
Contributor Author

Because word-wrap can be on and you can compose strings over multiple lines using +, I rather say regular as opposed to template, instead of single-line. WDYT?

That makes sense.

Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
@SleeplessByte
Copy link
Member

(Because you are doing this from main, we cannot run our format command. Next time it helps if you PR from a branch!)

@FFFF-0000h
Copy link
Contributor Author

(Because you are doing this from main, we cannot run our format command. Next time it helps if you PR from a branch!)

Haha. I knew there would be an issue when I deleted "patch-2" earlier. I don't mind creating a new PR, t for Thanks.

@FFFF-0000h
Copy link
Contributor Author

Wait, do you think it's best practice I create a new PR. I have searched and it seems Github doesn't allow changing the base in a PR, correct me if I'm wrong.
If not, we can go ahead and close this PR and deal with the newly created PR @ #2776

@Cool-Katt
Copy link
Contributor

@FFFF-0000h Since these are small PRs and they're basically identical in content, I'll let it slide this time, but usually we would like to avoid opening PRs left and right. In cases like this, if it's only the formatting CI complaining, usually one of the maintainers would have to run a format in a separate PR after merging and that's why it's extra work.

@SleeplessByte We should probably amend the CONRIBUTING.md or the general README.md with instructions about branch naming, but I'll open a forum post to talk.

@Cool-Katt Cool-Katt closed this Oct 2, 2025
@FFFF-0000h
Copy link
Contributor Author

@FFFF-0000h Since these are small PRs and they're basically identical in content, I'll let it slide this time, but usually we would like to avoid opening PRs left and right. In cases like this, if it's only the formatting CI complaining, usually one of the maintainers would have to run a format in a separate PR after merging and that's why it's extra work.

@SleeplessByte We should probably amend the CONRIBUTING.md or the general README.md with instructions about branch naming, but I'll open a forum post to talk.

Thanks @Cool-Katt, noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants