-
-
Notifications
You must be signed in to change notification settings - Fork 656
Enhance template string lesson with newline escape sequence demonstration #2769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
Forum post here: https://forum.exercism.org/t/clarity-on-template-strings/19454/2 |
SleeplessByte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because word-wrap can be on and you can compose strings over multiple lines using +, I rather say regular as opposed to template, instead of single-line. WDYT?
That makes sense. |
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
|
(Because you are doing this from |
Haha. I knew there would be an issue when I deleted "patch-2" earlier. I don't mind creating a new PR, t for Thanks. |
|
Wait, do you think it's best practice I create a new PR. I have searched and it seems Github doesn't allow changing the base in a PR, correct me if I'm wrong. |
|
@FFFF-0000h Since these are small PRs and they're basically identical in content, I'll let it slide this time, but usually we would like to avoid opening PRs left and right. In cases like this, if it's only the formatting CI complaining, usually one of the maintainers would have to run a format in a separate PR after merging and that's why it's extra work. @SleeplessByte We should probably amend the |
Thanks @Cool-Katt, noted. |
No description provided.