Skip to content

Extend initial mentor lock to 60mins #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Extend initial mentor lock to 60mins #5614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/commands/mentor/request/lock.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def call

Mentor::RequestLock.create!(
request:,
locked_until: Time.zone.now + 30.minutes,
locked_until: Time.zone.now + 60.minutes,
locked_by: mentor
)
end
Expand Down
2 changes: 1 addition & 1 deletion app/javascript/components/mentoring/request/StartMentoringPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const StartMentoringPanel = ({
Start mentoring
</button>
<div className="note">
You have 30 minutes until the session returns to the queue for others to
You have 60 minutes until the session returns to the queue for others to
mentor.
</div>
{status === 'loading' ? <Loading /> : null}
Expand Down
6 changes: 3 additions & 3 deletions test/commands/mentor/request/lock_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Mentor::Request::LockTest < ActiveSupport::TestCase

assert request.reload.locked?
lock = request.locks.last
assert_equal Time.current + 30.minutes, lock.locked_until
assert_equal Time.current + 60.minutes, lock.locked_until
assert_equal mentor, lock.locked_by
end
end
Expand All @@ -25,7 +25,7 @@ class Mentor::Request::LockTest < ActiveSupport::TestCase

assert request.reload.locked?
lock = request.locks.last
assert_equal Time.current + 30.minutes, lock.locked_until
assert_equal Time.current + 60.minutes, lock.locked_until
assert_equal mentor, lock.locked_by
end
end
Expand All @@ -40,7 +40,7 @@ class Mentor::Request::LockTest < ActiveSupport::TestCase

assert request.reload.locked?
lock = request.locks.last
assert_equal Time.current + 30.minutes, lock.locked_until
assert_equal Time.current + 60.minutes, lock.locked_until
assert_equal mentor, lock.locked_by
end
end
Expand Down