Skip to content

feat(reviews): add review convergence rules and informational severity#59

Merged
anderskev merged 1 commit intomainfrom
feat/verification-convergence-instructions
Feb 10, 2026
Merged

feat(reviews): add review convergence rules and informational severity#59
anderskev merged 1 commit intomainfrom
feat/verification-convergence-instructions

Conversation

@anderskev
Copy link
Member

Summary

Add review convergence instructions to all 6 review commands and informational severity category to all 6 verification protocols. This ensures reviews complete in 1-2 iterations instead of 5+ by enforcing single-pass completeness, scope boundaries, and re-review discipline.

Changes

Added

  • Review Convergence step to all review commands (review-elixir, review-go, review-tui, review-ios, review-python, review-frontend) with:
    • Single-pass completeness: report ALL issues in one pass, anticipate downstream issues
    • Scope rules: review only diff code, no net-new feature requests
    • Fix complexity budget: net-new code requests classified as Informational
    • Iteration policy: re-reviews verify previous fixes only, no new discovery
  • Informational severity category to all 6 verification protocol skills with clear criteria for non-blocking suggestions
  • Informational section in output format templates for all review commands
  • Convergence checklist items in Before Submitting Review sections

Changed

  • Verdict format updated across all review commands to only block on Critical/Major issues (Minor items are acceptable)
  • Verification protocol "Before Submitting" checklists updated with two new rules:
    • Downgrade findings that request net-new code to Informational
    • Re-reviews must only verify previous fixes

Motivation

Reviews were taking 5+ iterations because each round introduced new findings, requested net-new code (test suites, mock libraries, abstractions), and re-flagged minor issues. These convergence rules enforce disciplined review behavior: find everything once, respect scope boundaries, and treat re-reviews as verification passes.

Testing

  • Manual testing performed

Manual Testing Steps

  1. Run any review command (e.g., /beagle-python:review-python) on a branch with changes
  2. Verify the review includes a "Review Convergence" step and follows single-pass rules
  3. Verify the output format includes an "Informational" section
  4. Verify the verdict only considers Critical/Major issues as blocking

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated (changes are documentation)

Generated with Claude Code

…d verification protocols

Ensure reviews complete in 1-2 iterations instead of 5+ by adding:
- Review Convergence step (single-pass completeness, scope rules, fix
  complexity budget, iteration policy) to all 6 review commands
- Informational severity category to all 6 verification protocols
- Convergence verification steps to Before Submitting Review checklists
- Updated Verdict to only block on Critical/Major issues
- Informational section in Output Format templates

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@anderskev anderskev added the enhancement New feature or request label Feb 10, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Walkthrough

This pull request updates code review documentation across multiple language-specific plugins (Elixir, Go, iOS, Python, React, and core). The changes introduce standardized "Informational (No Action Required)" guidance for non-blocking findings and add a new "Review Convergence" workflow section addressing single-pass issue reporting, scope rules, fix complexity budgeting, and iteration policy. Pre-submission checklists are extended with steps to downgrade new-code requests to informational status and restrict re-reviews to verification of previous fixes only. Verdict interpretation is clarified to exclude Minor and Informational items from blocking approval decisions.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main changes: adding review convergence rules and informational severity categories across all review tools.
Description check ✅ Passed The description clearly relates to the changeset, outlining the specific additions (Review Convergence steps, Informational category) and changes (verdict format, checklist items) across all review commands and verification protocols.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@anderskev anderskev self-assigned this Feb 10, 2026
@anderskev anderskev merged commit ba69723 into main Feb 10, 2026
1 check passed
@anderskev anderskev deleted the feat/verification-convergence-instructions branch February 10, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant