Datamining #14
Merged
Datamining #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-rados
requested changes
Feb 22, 2020
nikola-rados
left a comment
nikola-rados
left a comment
There was a problem hiding this comment.
Nice work, this provides a really good base for us to work off of. I have a lot of comments, mostly styling or structural.
Contributor
Author
|
@nikola-rados Is this mergeable? |
nikola-rados
requested changes
Feb 26, 2020
nikola-rados
left a comment
nikola-rados
left a comment
There was a problem hiding this comment.
Nice work! I appreciate all the changes you made to accommodate my recommendations. There are a few small things I think should be looked at before merging.
Two additional items that I can't comment on in the code are:
- We probably only need a file or two of html in
data/ - Would you be able to add
the_mines/.DS_Storeto.gitignoreand take it out of the repo
Contributor
Author
|
@nikola-rados All re-request review changes have been implemented and pushed onto the branch. Let me know if I can merge. |
|
@maxUser merge away! |
nikola-rados
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_html.pywhich usesrequestsmodule to get raw htmlfussballdatenpunktde_matchday_results.pyto scrape basic matchday results datarun.pyto run both files in successionResolves #2
Special Notes
Expected Version Bump
Checklist:
black .