Clean up command after call #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2020 14:39
maxUser
reviewed
Jun 21, 2020
Contributor
maxUser
left a comment
maxUser
left a comment
There was a problem hiding this comment.
Is it possible to turn this on/off? While it looks cleaner for the user, it can be useful to see the command when testing/debugging.
Author
|
That’s a good idea, should it be a command line flag maybe? |
Author
|
@maxUser I thought it would be good to tie the message deletion to |
Contributor
Perfect, thank you! Merge away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #32
Special Notes
Thanks to the
discord.pyrewrite this was much simpler than it used to be. There is no need for use to factor our the process since it is already as simple as calling the built in method.We may want to think about better error handling. As of right now the bot crashes and tells us in the terminal, but a user would have no idea why the bot isn't replying. Removing the original command exasperates this issue since the user will not know what they did wrong. We should have
underscoreoutput a message when an error is thrown. Furthermore, we should consider providing better context in the embedded outputs. There is adescriptionparameter, where we could provide some info on the command (just a thought, this would probably get handled in the embed standardization).Suggested Version Bump
Checklist:
black .