Skip to content

i29 help page #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikola-rados merged 8 commits into from
Jun 28, 2020
Merged

i29 help page #44

nikola-rados merged 8 commits into from
Jun 28, 2020

Conversation

@maxUser
Copy link
Contributor

@maxUser maxUser commented Jun 28, 2020

Description

  • replaced default help command with custom help command that uses the parameters of the command decorator.
  • default help command used doc string, which is more developer focused.

Resolves #29

Special Notes

  • did not complete help command for individual commands (eg. !help blurb); add this to backlog

Suggested Version Bump

  • Major
  • Minor
  • Patch

Checklist:

  • I have run black .
  • I have made corresponding changes to the documentation - N/A
  • I have added tests that prove my fix is effective or that my feature works
  • I have added logging

@maxUser maxUser added the enhancement New feature or request label Jun 28, 2020
@maxUser maxUser added this to the Bison milestone Jun 28, 2020
@maxUser maxUser requested a review from nikola-rados June 28, 2020 20:14
@maxUser maxUser self-assigned this Jun 28, 2020
nikola-rados
nikola-rados approved these changes Jun 28, 2020
View reviewed changes
Copy link

@nikola-rados nikola-rados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nikola-rados nikola-rados merged commit 59ce187 into master Jun 28, 2020
@nikola-rados nikola-rados deleted the i29-help-page branch June 28, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikola-rados nikola-rados nikola-rados approved these changes

Assignees

@maxUser maxUser

Labels

enhancement New feature or request

Projects

None yet

Milestone

Bison

Development

Successfully merging this pull request may close these issues.

Help page

3 participants

@maxUser @nikola-rados