Skip to content

Conversation

@bullet-tooth
Copy link
Contributor

Overview


Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@dmitry-timofeev dmitry-timofeev added the work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly! label May 24, 2019
@dmitry-timofeev
Copy link
Contributor

I am not sure I get this:

  1. We shall merge updates from release branch once LC is out, not duplicate them
  2. This won't built as 0.2.0 is not on central, will it?

@bullet-tooth bullet-tooth changed the base branch from master to ejb/v0.6.0-release May 24, 2019 11:02
@bullet-tooth bullet-tooth changed the base branch from ejb/v0.6.0-release to jlc/v0.2.0-release May 24, 2019 11:03
@bullet-tooth
Copy link
Contributor Author

Ups, I missed the base branch.

@dmitry-timofeev dmitry-timofeev merged commit 1b20293 into jlc/v0.2.0-release May 24, 2019
@dmitry-timofeev dmitry-timofeev deleted the add-plugin-versions branch May 24, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly!

Development

Successfully merging this pull request may close these issues.

3 participants