fix(config): improve config override behavior#817
Open
nhedger wants to merge 3 commits intoexoscale:masterfrom
Open
fix(config): improve config override behavior#817nhedger wants to merge 3 commits intoexoscale:masterfrom
nhedger wants to merge 3 commits intoexoscale:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Disclosure:
Description
Fixes #737
This updates config resolution so environment variables override account credentials without discarding the rest of the selected profile.
Previously, when
EXOSCALE_API_KEYandEXOSCALE_API_SECRETwere set, the CLI returned early during config initialization and skipped loading the config file entirely. As a result, profile values such asdefaultZonewere ignored and commands relying on the account default zone could fall back to the built-in default instead of the zone configured inexoscale.toml.This change now:
defaultZoneand other account defaultsThis fixes the override precedence so env credentials replace authentication settings, not the whole profile.
Checklist
(For exoscale contributors)
CHANGELOG.md)Testing
go test ./...go test -run 'TestScriptsLocal/(show_with_env_credentials_keeps_config_defaults|show_with_env_credentials_without_config)$' -count=1 ./...fromtests/e2edefaultZonefrom the config is preserved when env credentials are set