Conversation
Contributor
Author
|
@Osburg: can you have a look at this? |
Osburg
approved these changes
Mar 12, 2025
Collaborator
There was a problem hiding this comment.
Hey @jduerholt, sure, this is fine, thanks :) Once the PR #525 is finished and merged I'll check if these error still occur frequently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The test pipeline is crashing quite often due to some numerical noise in DoE optimization. For stability reasons, I set
raise_validation_error=Falsefortest_functional_constraintas it was done already by @Osburg for some other doe related tests.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Unit tests.