Fix "global flags not at the start" raised in extract_text function #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…describing the change, you could use:
…message describing the change, you could use:" This reverts commit bb1eab4.
dosubot
bot
added
the
size:M
dosubot
bot
added
size:L
Add changes
Revert "Iter v3"
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the "global flags not at the start" error in the RulebasedExtractor class. The merge_extractors function has been updated to handle regex flags correctly when combining multiple extractors.
Fixes #1112
Changes:
Modified merge_extractors to extract flags from the beginning of each pattern
Implemented wrapping of individual patterns in non-capturing groups with their respective flags
Ensured that the merged pattern preserves flags for each subpattern
This fix allows for proper handling of regex flags when merging extractors, preventing the "global flags not at the start" error while maintaining the functionality of individual extractor patterns.