Fixing Demo Code - Compare Embeddings for retriever Docs #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Member
|
@matheusft thank you so much for the PR and fixing the docs ❤️ 🙌🏽 |
Gwenn-LR
pushed a commit
to Gwenn-LR/ragas
that referenced
this pull request
Aug 5, 2024
…adients#1153) The code examples from `docs/howtos/applications/compare_embeddings.md` were missing important lines e.g. missing the `TestsetGenerator` import and assigning `test_df` before using it. This pull request adressess these minor improvements. --------- Co-authored-by: Matheus Torquato <mtorquat@jaguarlandrover.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code examples from
docs/howtos/applications/compare_embeddings.mdwere missing important lines e.g. missing theTestsetGeneratorimport and assigningtest_dfbefore using it.This pull request adressess these minor improvements.