Skip to content

Conversation

@shahules786
Copy link
Member

@shahules786 shahules786 commented Nov 4, 2024

Adds persona to diversify test set generation

from ragas.testset.persona import PersonaList
persona_list = await PersonaList.from_kg(llm=generator_llm, kg=kg)

@shahules786 shahules786 marked this pull request as ready for review November 4, 2024 11:08
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 4, 2024
@shahules786 shahules786 requested a review from jjmachan November 4, 2024 11:08
@shahules786 shahules786 requested a review from jjmachan November 5, 2024 13:23
@jjmachan
Copy link
Member

jjmachan commented Nov 6, 2024

made 2 changes to this

from ragas.testset.persona import generate_personas_from_kg
persona_list = generate_personas_from_kg(kg=kg, llm=generator_llm)

generation being a class method, I was wrong about that one, and added executor to make things parallel at the function level.

let me know if this is good or else I'll revert these changes

@shahules786 shahules786 merged commit 02e7a46 into explodinggradients:main Nov 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants