Migrate factual correctness #2401
Draft
+612
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
anistark
reviewed
Nov 5, 2025
Member
anistark
left a comment
anistark
left a comment
There was a problem hiding this comment.
ascore implementation executes verification sequentially.
We can probably execute these in parallel, which is sequential right now:
- Verify response claims against reference
- Verify reference claims against response
thoughts?
| statements: List[StatementFaithfulnessAnswer] | ||
|
|
||
|
|
||
| def claim_decomposition_prompt( |
Member
There was a problem hiding this comment.
do we need this method here or can we place it somewhere in common ragas.prompt.metrics.common
|
|
||
| # Ensure implementations give reasonably similar scores | ||
| # Factual correctness may have more variation due to claim decomposition and different LLM behavior | ||
| assert score_diff < 0.35, ( |
Member
There was a problem hiding this comment.
35% tolerance is too high, no? Is it intended? Can it be lowered to 10-15 % ?
|
|
||
| return MetricResult(value=float(np.round(score, 2))) | ||
|
|
||
| async def _decompose_claims(self, response: str) -> List[str]: |
Member
There was a problem hiding this comment.
We're missing callbacks in this and _verify_claims methods.
Is it intended? Callbacks would help in analysis and tracing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.