Skip to content

fix: n_swapped check for generate #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix: n_swapped check for generate #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ragas/metrics/llms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ def generate(
n: t.Optional[int] = None,
) -> LLMResult:
old_n = None
n_swapped = False
if n is not None:
if isinstance(llm, OpenAI) or isinstance(llm, ChatOpenAI):
old_n = llm.n
llm.n = n
n_swapped = True
else:
raise Exception(
f"n={n} was passed to generate but the LLM {llm} does not support it."
Expand All @@ -36,6 +38,6 @@ def generate(
ps = [p.format_messages() for p in prompts]
result = llm.generate(ps)

if isinstance(llm, OpenAI) or isinstance(llm, ChatOpenAI):
if (isinstance(llm, OpenAI) or isinstance(llm, ChatOpenAI)) and n_swapped:
llm.n = old_n # type: ignore
return result