Skip to content

Conversation

@jjmachan
Copy link
Member

No description provided.

@hinthornw
Copy link

@jjmachan happy to help if there's anything blocking this release! Would love to land so we can share more broadly (https://github.com/langchain-ai/langsmith-cookbook/blob/main/testing-examples/ragas/ragas.ipynb)

@jjmachan jjmachan marked this pull request as ready for review March 28, 2024 15:43
Co-authored-by: Massimiliano Pronesti <massimiliano.pronesti@gmail.com>
@jjmachan
Copy link
Member Author

thanks for the catch @mspronesti 🙌🏽

ps: will add docs soon but feel free to look at https://notes.explodinggradients.com/en/latest/RAG-Experiments/basecamp-handbook/baseline-langchain.html for how to use this in action, I'll docs in the mean time

@mspronesti
Copy link
Contributor

mspronesti commented Mar 28, 2024

@jjmachan I accidentally misspelled Optional with an "r" in my suggestion. Beware 😅

@jjmachan
Copy link
Member Author

no worries - I missed it but at least our linters caught it 😂

@jjmachan jjmachan merged commit 6d38222 into explodinggradients:main Mar 28, 2024
@jjmachan jjmachan deleted the feat/langchain branch March 28, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants