EAS Submit does not take ENV VARs (like APP_VARIANT) from profile or eas.json environment

[dbrekelmans]

Build/Submit details page URL

No response

Summary

When running eas submit --profile production, and having eas.json configured with:

"production": {
      "autoIncrement": true,
      "channel": "production",
      "environment": "production"
    }

The command does not take environtment variables configured in the production environment.

For example:

I use process.env.APP_VARIANT in my app.config.ts to determine the bundle identifier, and default to development if the env var is not set. I've noticed in eas submit that the env var is not set, to it submits with my dev bundle identifier.

I think it should work for eas submit in the same way it works for eas build according to https://docs.expo.dev/eas/environment-variables/

Managed or bare?

Managed

Environment

bunx expo-doctor                                                                                                                                                                                                                                                    
env: load .env.local
env: export APP_VARIANT EXPO_PUBLIC_SENTRY_DSN SENTRY_AUTH_TOKEN
15/15 checks passed. No issues detected!

Error output

No response

Reproducible demo or steps to reproduce from a blank project

1. Set up the APP_VARIANT environment variable in EAS for the production environment
2. Configure the production profile in eas.json to use the production environment
3. Determine the bundle identifier in app.config.ts to be based on process.env.APP_VARIANT
4. Run eas submit --profile production
5. Observe that the APP_VARIANT environment variable is not set

[kadikraman]

For the time being, I'd suggest putting the APP_VARIANT under env for each profile in your eas.json.

I haven't checked this exact scenario so I might be wrong, but I believe the underlying problem is that when the app config is first evaluated on your local machine, no EAS env vars can be used. That's because your projectId (which tells us which project to pull the env vars from) is also in the app config. Chicken and egg I guess... So it'll use the values in your local env file (or if there are none, your fallback).

We could allow passing your project ID into the EAS command, but that's quite inconvenient and not a real fix.

Alternatively, we need to store the project ID somewhere else. So, the question is where.

[dbrekelmans]

But this feature works for eas build according to https://docs.expo.dev/eas/environment-variables/#use-environment-variables-with-eas-build, wouldn't it be able to work for other commands as well?

Is the "temp" solution to pass --environment=production like https://docs.expo.dev/eas/environment-variables/#use-environment-variables-with-eas-build?

[ashgharibyan]

For the time being, I'd suggest putting the APP_VARIANT under env for each profile in your eas.json.

I haven't checked this exact scenario so I might be wrong, but I believe the underlying problem is that when the app config is first evaluated on your local machine, no EAS env vars can be used. That's because your projectId (which tells us which project to pull the env vars from) is also in the app config. Chicken and egg I guess... So it'll use the values in your local env file (or if there are none, your fallback).

We could allow passing your project ID into the EAS command, but that's quite inconvenient and not a real fix.

Alternatively, we need to store the project ID somewhere else. So, the question is where.

Ive have it set in the env inside the eas.json, and still when im doing eas build it works it builds with correct env APP_VARIANT.
But when Im doing eas submit, i can see in the logs that it is taking the dev (default) APP_VARIANT for both the name of the app and the bundle id.

BUT, in the App Store Connect, it builds under the correct APP with production bundle id, and the build actually has the product id. So I assume that the logs that are being printed are referencing the wrong env variable or not at all, but when submitting its using the correct one.

LOGS:
myapp git:(dev) ✗ eas submit
✔ Select platform › iOS
✔ What would you like to submit? › Select a build from EAS
✔ Which build would you like to submit? › - ID: ------ (51 seconds ago)
Ensuring your app exists on App Store Connect. This step can be skipped by providing ascAppId in
the submit profile. Learn more: https://expo.fyi/asc-app-id

› Log in to your Apple Developer account to continue
✔ Apple ID: … myapp@gmail.com
› Restoring session /Users/---/.app-store/auth/myapp@gmail.com/cookie
› Team --- Inc. (---)
› Provider --- Inc. (---)
✔ Logged in Local session

✔ Bundle identifier registered com.myapp.chef.dev
✔ Prepared App Store Connect for MyApp (Dev) com.myapp.app.dev
Looking up credentials configuration for com.myapp.app.dev...
✔ App Store Connect API Key already set up.

---

but on the App Store Connect the app is built under the correct App and the build metadata has the correct bundle id.

Idk if the incorrect one is saved somewhere else, or this is a bug in Expo logs

[evrimfeyyaz]

@kadikraman This makes EAS Submit virtually unusable when using environment variables.